search

PMEAL / OpenPNM

A Python package for performing pore network modeling of porous media
http://openpnm.org
MIT License
442 stars 175 forks source link

Create openpnm.models.health_checks submodule for storing the new health check functions #2109

Closed jgostick closed 2 years ago

jgostick commented 2 years ago

So:

openpnm
  - models
    - health_checks
      - topopolgy
        - duplicate_pores
        - etc
      - subdomains
        - unassigned_locs
      - data_integrity
        - has_nans

Then we can call these from the project.check_<...>_health() functions.

The only wierdness is that 'models' are generally meant to be assigned to objs and the results stored on the objs, so this breaks things. Another option might be to put health_checks under the topotools folder or perhaps utils?

ma-sadeghi commented 2 years ago

Yeah, maybe topotools or utils is a better place than models.