Closed jgostick closed 1 year ago
Merging #2857 (79e81d6) into release (3dbe3e5) will decrease coverage by
0.2%
. Report is 2 commits behind head on release. The diff coverage is45.0%
.:exclamation: Current head 79e81d6 differs from pull request most recent head 8e320be. Consider uploading reports for the commit 8e320be to get more accurate results
@jgostick Given that Matplotlib is going to remove this module altogether, can't we just host the code in our side? I think the license allows it.
The windows builds are failing because the pypardiso team is having trouble with mkl again. They have a lot of recent activity and I'm sure they'll get this fixed soon. I am tempted to merge this now so we can get the pip release working with all version of mpl, which is more important than pardiso, I think?
Maybe give them just a few more days? Either the issue is on pypardiso side, which I think will get fixed soon, or on Intel side, which probably won't get fixed soonish
But technically pypardiso is not in our dependencies. This is only failing because we use it in some of our tests...but you're right, lets give it a few more days.
The deprecation of the
matplotlib.docstring
module tomatplotlib._docstring
was fixed in our previous patch, BUT it was not compatible with both new and old versions of matplotlib, so this patch uses a try/except to work with both versions.