search

PMEAL / OpenPNM

A Python package for performing pore network modeling of porous media
http://openpnm.org
MIT License
444 stars 174 forks source link

Proper Brevais Lattices #505

Closed jgostick closed 8 years ago

jgostick commented 8 years ago

The DelaunayCubic class is great, but needs to be renamed to BravaisLattice. This is the general term for any cubic packing and there is well-defined notation for the lattice structure which should be given as the arguments. See Wikipedia.

Basically, we need to produce some system of arguments that can reproduce all the arrangements there. I love the idea of skewed networks too!

TomTranter commented 8 years ago

I like this idea. Also with actual structures it is more likely that the lattice points are solid particles or agglomerates rather than pores. It would be cool if you could produce a network treating points as either solid or void. I think this would more or less entail swapping the pore coordinates with the vertices of a Voronoi diagram.

jgostick commented 8 years ago

I'd like to make this one of the key new features of V1.5.

jgostick commented 8 years ago

This is probably not a good thing to spend time on. There is already the DelaunayCubic with does this sort of by specifying 'bcc' or 'fcc'. I think that class should be renamed to be more descriptive, but that means breaking things. Let's close this for now and revisit if and when it makes sense.