search

PMEAL / OpenPNM

A Python package for performing pore network modeling of porous media
http://openpnm.org
MIT License
442 stars 175 forks source link

Should topological manipulation be allowed after other objects are added? #928

Closed jgostick closed 6 years ago

jgostick commented 6 years ago

We do allow this in some cases, but I think we should NOT. This would make the topotools even more general for future transfer to a separate graph package.

jgostick commented 6 years ago

I have just rewritten trim and it now handles cases with and without other object separately. If all other objects are the same length as the network then it goes fast, if some objects are a different size it resorts to mapping, but now uses int ids instead of uuids, so is also much faster.