search

PMEAL / porespy

A set of tools for characterizing and analying 3D images of porous materials
https://porespy.org
MIT License
301 stars 98 forks source link

Fix `points_to_spheres` bug in 3D #932

Closed heinsimon closed 4 months ago

heinsimon commented 6 months ago

Closes #917

heinsimon commented 6 months ago

I added a simple test case for 2D and 3D.

I did not add anything for im being a boolean array, since I do not really know what the expected output would be. It feels broken, but I do not know for sure.

ma-sadeghi commented 6 months ago

I added a simple test case for 2D and 3D.

I did not add anything for im being a boolean array, since I do not really know what the expected output would be. It feels broken, but I do not know for sure.

That seems strange, I can't look at it right now, but will do later this week.

heinsimon commented 4 months ago

Is this PR still considered or is it outdated now?

ma-sadeghi commented 4 months ago

Sorry for the delay. I still didn't get the chance to review it. Will do this week hopefully.

jgostick commented 4 months ago

I'm so sorry how long this is taking. Amin has a new job now, so it's all on me at the moment. I think the PR is pretty much ready, I'll just go in and fix the tests myself asap.

jgostick commented 4 months ago

I see that "maintainers are allowed to edit this pull request" is enabled, but I honestly don't know how. I would have expected to see this as a branch on my remote which I could pull locally to work on, but that is not how it works. Soooo, I'm just going to merge it into dev, then create a new PR to fix the tests.