search

PMEAL / porespy

A set of tools for characterizing and analying 3D images of porous materials
https://porespy.org
MIT License
301 stars 98 forks source link

change volume_fraction to phi throughout #947

Closed jgostick closed 6 months ago

jgostick commented 6 months ago

random_spheres and cylinders (soon to be random_cylinders) have a volume_fraction argument which is too verbose. Should be changed to phi instead, which is used on the pseudo packing functions.

jgostick commented 6 months ago

Hmmm, just remembered that phi is also used as the secondary angle in spherical coordinates and is used in cylinders (actually phi_max)

jgostick commented 6 months ago

I went ahead and did this in PR #948