search

PMKS-Web / PMKSWeb

An educational web-based tool designed for comprehensive 2D linkage analysis developed at WPI (Worcester Polytechnic Institute)
https://pmksplus.com
3 stars 2 forks source link

104 #115

Closed KohmeiK closed 1 year ago

KohmeiK commented 1 year ago

I'm not gonna fix the input toggle since I'm goning to replace all of them with a 'Set as Input' button instead

netlify[bot] commented 1 year ago

Deploy Preview for pmks ready!

Name Link
Latest commit f5ee8fa3da0a78828a2b750505ba184bcaf946f1
Latest deploy log https://app.netlify.com/sites/pmks/deploys/64c1ed3374b99100070655b7
Deploy Preview https://deploy-preview-115--pmks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JMRhodes03 commented 1 year ago

https://photos.app.goo.gl/BCssgY5barWm7bai7 found a bug: when working with a slider that is horizontal from the adjacent grounded joint, trying to manipulate the input function of said slider faces many weird glitches, if using right click, it sets the adjacent grounded joint as input instead. and when using the edit menu once it is selected as input it cannot be unselected and the toggle remains in the negative positon.

AlexG1031 commented 1 year ago

@JMRhodes03 This is an interesting bug that you found. The function for setting the input joint will have to be adjusted a bit. I believe in your video, the reason why this is happening is that the code is looking for the first instance of a grounded joint, which it finds at Joint A instead of Joint C.... Good edge case!

AlexG1031 commented 1 year ago

bugInputSlider Found within link that mechanism positions cannot be found at certain joint positions. This will need to be examined further...

AlexG1031 commented 1 year ago

@Kohmei358 We have to update the context menu for when the user right clicks on the slider crank. When the user right-clicks, they are selecting the revolute joint. Users cannot select the prismatic joint. I think for this special case when the user selects the revJoint that is on top of the prismatic joint, we have to showcase the context menu for that joint rather than for the revolute joint. Let me know if this makes sense. I believe I will have to ask you for this part.

AlexG1031 commented 1 year ago

I found a bug. Create Link >> Add ground >> Add Input >> Add slider. Finish creating slider crank. Mechanism positions are not found and somewhere the application produces an error.