search

PMKS-Web / PMKSWeb

An educational web-based tool designed for comprehensive 2D linkage analysis developed at WPI (Worcester Polytechnic Institute)
https://pmksplus.com
3 stars 2 forks source link

Calculation bug for 6-Bar mechanism secondary loops helps with #92 #122

Open JMRhodes03 opened 1 year ago

JMRhodes03 commented 1 year ago

bug found when working on Problem 92, the mechanisim does not properly perform kinematics on the Joint E position. when looking into code it seems as though loop ABDEFGA is not considered a requiredLoop when it should be. So in this method, we have to adjust this algorithm so that we do consider ABDEFGA as a required loop and not just ABCGA.

Image

JMRhodes03 commented 1 year ago

Image

according to a video from Pradeep, both loops of the mechanism are necessary for proper kinematic calculations.

AlexG1031 commented 1 year ago

Updated logic within Simulator class that determines requiredLoops. RequiredLoops should be determined now for all valid mechanisms.

If there is another instance where a joint does not contain a velocity or acceleration, let me know. But I believe this issue is completed.

AlexG1031 commented 1 year ago

I pushed my code onto branch 92. Please compare with that respective branch.