search

PMKS-Web / PMKSWeb

An educational web-based tool designed for comprehensive 2D linkage analysis developed at WPI (Worcester Polytechnic Institute)
https://pmksplus.com
3 stars 2 forks source link

Fixes #94 and #84. Redo SVGGrid to keep zoom level persistent on Resize fixing bugs and allowing smoother unit changes. #128

Closed KohmeiK closed 1 year ago

netlify[bot] commented 1 year ago

Deploy Preview for pmks ready!

Name Link
Latest commit bb57f21323396ac3712aae2500766c1c48479757
Latest deploy log https://app.netlify.com/sites/pmks/deploys/64c1df70371bd90008221a02
Deploy Preview https://deploy-preview-128--pmks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AlexG1031 commented 1 year ago

Hi @KohmeiK, nice job on fixing 94 and 84!

I found a bug that will require to take a look at.

showKohmei

When you change to SI, for whatever reason, the ground joint disappears. When you change back to English and Metric, the ground joints appear again.

Also, I have a thought that I will want to ask about. In my mind, when the user inserts the joint values, they have a desired unit in mind but they do not know what the default global unit is. I suspect that students (novice users) will create a mechanism, go to settings, change the unit, and have to recreate the mechanism. With the way that this is set up, it implies that settings have to be done first, and then the mechanism will need to be created. However, users may not think in this order and they will want to create the mechanism first and then change the settings. In my mind, I think when the user changes the unit, neither the grid nor the mechanism should change. Curious to hear what you think.

KohmeiK commented 1 year ago

I'm stumped on the first issue. It doesn't happen on Safari and I don't know how to fix it on Chrome. Would love some help if someone else can take a look.

Oh I see where you're coming from. You're saying if a student never opens the edit panel, they won't notice the length units. Maybe the solution is to add a small unit indicator on the grid?

KohmeiK commented 1 year ago

Seems like anything less than object scale 0.5 breaks the SVG graphics on Chromium. How weird...

AlexG1031 commented 1 year ago

One potential quick solution would be to not change the grid size. This may break other parts of code that showcases the scale but we can deal with these problems once we come across them...