search

PMKS-Web / PMKSWeb

An educational web-based tool designed for comprehensive 2D linkage analysis developed at WPI (Worcester Polytechnic Institute)
https://pmksplus.com
3 stars 2 forks source link

Simulation welded joints #131

Closed AlexG1031 closed 1 year ago

AlexG1031 commented 1 year ago

Users can now create welded joints, which will allow users to create link shapes as they please.

netlify[bot] commented 1 year ago

Deploy Preview for pmks ready!

Name Link
Latest commit 2bbbb6d0522189776604bac973a4dad78b6b9909
Latest deploy log https://app.netlify.com/sites/pmks/deploys/64cb0b5ee85c480008b5d885
Deploy Preview https://deploy-preview-131--pmks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

KohmeiK commented 1 year ago

Really great work solving such a complex problem! 95% of the use cases are good now but I noticed a couple of issues:

One: Creating a tracer in the fillet section breaks a couple of things. I need to disable this in the context menu but you should probably block adding a tracer to the link without adding to a specific subset too. One

Two: You can end up with compound link that is two separate links. When a connecting joint is deleted it should be converted to two links again. Two

Three: This maybe out of scope since it deals with weird circular connections but this works when I don't set one of the joints as a ground and input which is weird. Three

KohmeiK commented 1 year ago

I'm sorry you're probably sick of working on welded joints by now

AlexG1031 commented 1 year ago

Hi Kohmei, These are great edge cases that you have found! I can figure out what is causing these bugs and fix it so we don't have these strange behaviors.

1: Will look into this soon. 2: Believe this is fixed now. 3: Believe this is fixed now.

AlexG1031 commented 1 year ago

I noticed that fixedLocations within the link's subset is not properly updated when we add a tracer point onto a link (I think we add the fixed point within the link itself and not the subset if this is the case condition). This will not be a problem within creating mechanisms but once we showcase FBDs and we do not see an option for attaching a certain joint as a fixed location. We can fix this problem once we showcase FBDs

AlexG1031 commented 1 year ago

For 3, I believe the way that data is stored within joints is incorrect. There is a case where there is a duplicate within connectedJoints, which is based on when you add welded logic.

Should be fixed now

showKohmei

AlexG1031 commented 1 year ago

showcasing case 2: showKohmei