PMKS-Web / PMKSWeb

An educational web-based tool designed for comprehensive 2D linkage analysis developed at WPI (Worcester Polytechnic Institute)
https://pmksplus.com
4 stars 3 forks source link

Can't animate valid linakge #14

Closed KohmeiK closed 2 years ago

KohmeiK commented 2 years ago
  1. Open a 4 bar templae.
  2. Edit the shape of link b-c
  3. Select the 2nd shape (bar with infinite joints)
  4. Add tracer point to link b-c
  5. Remove tracer point
  6. I can't animate the link anymore

Image

http://localhost:4200/?j=a,-1.24,-0.89,ab,R,t,Null,t%0Ab,-0.1,2.01,ab%7Cbc,R,f,Null,f%0Ac,4.26,2.27,bc%7Ccd,R,f,Null,f%0Ad,3.36,-1.01,cd,R,t,Null,f%0A&l=ab,R,1,1,-0.67,0.5599999999999998,a%7Cb,,line,-0.1,-0.89,-0.1,2.01,-1.24,2.01,-1.24,-0.89%0Abc,R,1,1,2.08,2.1399999999999997,b%7Cc,,line,4.26,2.01,4.26,2.27,-0.1,2.27,-0.1,2.01%0Acd,R,1,1,3.8099999999999996,0.63,c%7Cd,,line,3.36,2.27,3.36,-1.01,4.26,-1.01,4.26,2.27%0A&f=&s=10,false,false,cm

KohmeiK commented 2 years ago

Pretty sure this is a issue with validMechanism() [animation-bar.compoenent Line 156]. I'm gonna delicate to @AlexG1031 since i know you're working on DOF calculation stuff. Again, let me know, if I should dig further into this

AlexG1031 commented 2 years ago

Nothing to do with validMechanism or DOF. This is another problem where deleting joint is not finished. Link needs to know that that joint has been deleted. Also, link id needs to change since link id comes from the joint ids.