search

PMKS-Web / PMKSWeb

An educational web-based tool designed for comprehensive 2D linkage analysis developed at WPI (Worcester Polytechnic Institute)
https://pmksplus.com
3 stars 2 forks source link

Change naming of input and ground label #145

Closed AlexG1031 closed 1 year ago

AlexG1031 commented 1 year ago

Change ground and input label to "Ground Joint" and "Attach Input".

netlify[bot] commented 1 year ago

Deploy Preview for pmks ready!

Name Link
Latest commit ee796ba4cdacd048e414f182d2982d468480dde4
Latest deploy log https://app.netlify.com/sites/pmks/deploys/64c03631a8bac1000867be00
Deploy Preview https://deploy-preview-145--pmks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rkprad commented 1 year ago

Looks good.

KohmeiK commented 1 year ago

@rkprad @AlexG1031 I wanted to change these labels last year but Prof Brown said that there was a lot of thought and deliberation about these names so we decided to keep it.

It was: Add Ground <-> Remove Ground Add (Set) Input <-> Remove Input

You changed it to: Ground Joint <-> Remove Ground Attach Input <-> Remove Input

(maybe it could be 'make input')

I think Ground Joint could be confusing since it's not clear if Ground is used an adjective or verb. (All other context menu items start with a verb.) Also the symmetry of Add / Remove is gone. If we want "Ground Joint" it should probably be "Unground Joint"

Just some thoughts, I don't have a string preference for what we do though

rkprad commented 1 year ago

the pmksplus.mech.website has different labels compared to this new one. So, the option was either to go with what's available in the currently used version or have the new one but adjust it. That's why I adjusted them to be more appropriate from a kinematics and mechanisms perspective.

For now, let the new change be as is. As I use this more, I'll see how this works and then decide.