search

PMKS-Web / PMKSWeb

An educational web-based tool designed for comprehensive 2D linkage analysis developed at WPI (Worcester Polytechnic Institute)
https://pmksplus.com
3 stars 2 forks source link

Force deletes when deleting a links #146

Closed AlexG1031 closed 1 year ago

AlexG1031 commented 1 year ago

When a user deletes a link and the link has a force that is attached to a link, the force will also delete

netlify[bot] commented 1 year ago

Deploy Preview for pmks ready!

Name Link
Latest commit e986e4e014ffd8174d7a62d90cb3919d7ed15995
Latest deploy log https://app.netlify.com/sites/pmks/deploys/64ecb2f83d79680007b2a62c
Deploy Preview https://deploy-preview-146--pmks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rkprad commented 1 year ago

image The above image works well. The below image also works image

rkprad commented 1 year ago

Alex found the exact issue as to why deletion did not work well.

AlexG1031 commented 1 year ago

I am glad you found this bug Kohmei. Knowing the data structure, I know that force is stored within the subset and not within the link itself. If you tried to determine the analysis, there is strong chance that that force would not have been accounted for that link.

So for this bug, when you weld a joint, we have to iterate through each subset and make sure that the force is added within the link. I can account for this most likely during this weekend.