search

PMKS-Web / PMKSWeb

An educational web-based tool designed for comprehensive 2D linkage analysis developed at WPI (Worcester Polytechnic Institute)
https://pmksplus.com
3 stars 2 forks source link

Remove slider sets joint's ground to false #150

Closed AlexG1031 closed 1 year ago

AlexG1031 commented 1 year ago

Removing a slider will now set the joint as a tracer joint rather than a grounded joint

netlify[bot] commented 1 year ago

Deploy Preview for pmks ready!

Name Link
Latest commit b4e6cc5b9f7d1e7d72992538caa82a96fa0e4d9f
Latest deploy log https://app.netlify.com/sites/pmks/deploys/64c05b660b59240008b48fd6
Deploy Preview https://deploy-preview-150--pmks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rkprad commented 1 year ago

The above issue has been solved but another thing has popped up, Add Ground -> Make Input -> Add Slider - produces an issue with incorrect slider representation. IDeally, this should be a slider with input. image

AlexG1031 commented 1 year ago

This issue is resolved in another GitHub issue: https://github.com/PMKS-Web/PMKSWeb/pull/115. I can merge this with 104 and we can close this.

AlexG1031 commented 1 year ago

Merged with 104.