PMKS-Web / PMKSWeb

An educational web-based tool designed for comprehensive 2D linkage analysis developed at WPI (Worcester Polytechnic Institute)
https://pmksplus.com
3 stars 2 forks source link

Undo/Redo, Save/Load #189

Closed AnselChang closed 1 year ago

netlify[bot] commented 1 year ago

Deploy Preview for pmks ready!

Name Link
Latest commit 3bb49364196a58506e454a8bb0cef10d4265a3c8
Latest deploy log https://app.netlify.com/sites/pmks/deploys/64ee1aac1e639f0008a065a2
Deploy Preview https://deploy-preview-189--pmks.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AlexG1031 commented 1 year ago

@AnselChang Very nice job within copy links and undo/redo.

AlexG1031 commented 1 year ago

Very tiny thing, honestly insignficant, but just wanna document this:

UndoAnsel

Not sure how come but when I undo/redo adding a welded joint and an input joint, it combines these two as one step rather than two.

Code currently looks good enough to me though to accept!

AnselChang commented 1 year ago

Very tiny thing, honestly insignficant, but just wanna document this:

UndoAnsel

Not sure how come but when I undo/redo adding a welded joint and an input joint, it combines these two as one step rather than two.

Code currently looks good enough to me though to accept!

Fixed! Please let me know if you find other minor things like this, as I have to manually add save states for every important event.

KohmeiK commented 1 year ago

It looks like a lot of this works when using the context menu but not when using the edit panel. Can you double check? @AnselChang

Input, Ground (Only from edit panel), Slider, forces (non dragging actions), link colors, show path and probably more stuff in primarily in the edit panel

KohmeiK commented 1 year ago

@AnselChang will take a look at updating the things that broke from the merge and will take a look at the panel linking issue