Folder icons are not present for embedded workspaces for the workspace file listing

PMR2 / pmr2.app

Physiome Model Repository 2 (PMR2) core package.

https://www.physiomeproject.org/

1 stars 1 forks source link

Folder icons are not present for embedded workspaces for the workspace file listing #8

Closed jonrkarr closed 2 years ago

jonrkarr commented 2 years ago

Example: https://models.physiomeproject.org/workspace/705/@@file/a3428d102cec10f55c51c13731a78e812f9bab04/

GPCR_B1AR_reduced
GPCR_M2_reduced
cAMP
units_and_constants

metatoaster commented 2 years ago

These are not folders but are embedded workspaces, which are links to other git repositories which may be other workspaces.

Yes this is a known issue.

jonrkarr commented 2 years ago

In that case, ideally the icon would indicate a Git submodule.

metatoaster commented 2 years ago

Agreed. This was implemented back with the Mercurial based workspaces, but for some reason this broke in Git but nobody seemed to care, but yes this should be fixed.

metatoaster commented 2 years ago

Deployed to production.