search

PMSI-AlignAlytics / dimple

An object-oriented API for business analytics
Other
2.73k stars 556 forks source link

add g elements (groups) for each series added to a chart. #207

Closed jjimenez closed 8 years ago

jjimenez commented 8 years ago

Use in plots and with markers.

Fixing issue #203 See http://jsfiddle.net/jose_jimenez/1fvjvyvh/3/ for before and (clumsily) http://jsfiddle.net/jose_jimenez/1fvjvyvh/4/ for after. I copied the latest.js into the jsfiddle.

I verified that all the charts in the examples rendered after the changes and that tests passed. This should also make it easier for someone to remove or hide all the shapes for one series at the same time.

johnkiernander commented 8 years ago

I've just pulled and tested this, it's a nice improvement thank you. I'll merge it now.