search

PMSI-AlignAlytics / dimple

An object-oriented API for business analytics
Other
2.73k stars 556 forks source link

Update _parentWidth.js #219

Closed laxgeek closed 8 years ago

laxgeek commented 8 years ago

The firefox issue (https://bugzilla.mozilla.org/show_bug.cgi?id=649285) was closed as invalid. Chrome is also deprecating offsetWidth and offsetHeight in April 2016. parent.getBoundingClientRect().width is a more explicit call to get the outer object width

disdanes commented 8 years ago

Any reason why this hasn't been merged yet ? Deprecation is less than a month away.

laxgeek commented 8 years ago

Good question! I don't have write access, so it's above my pay grade for merging. :smirk:

johnkiernander commented 8 years ago

Sorry it's been a bit hectic here. I'll merge it in this week once I've had a chance to test it (and the other outstanding PRs). Don't worry though, old versions of Dimple will continue to work after the Chrome version change, as the affected code already has a fall back in place.

laxgeek commented 8 years ago

@johnkiernander No worries! I figured you had it under control. :relaxed: I didn't want @disdanes to feel ignored. Worst case is that the user sees a warning in the console and the page loads as expected.

disdanes commented 8 years ago

Np. I've just been tracking the deprecation for a client and wanted to make sure this got some visibility :)