search

PMheart / CoreDisplayFixup

Enable 4K or greater resolution for all graphics under macOS
75 stars 13 forks source link

Added additional CoreDisplay patches for 10.13.4+ #7

Closed al3xtjames closed 6 years ago

al3xtjames commented 6 years ago

This is a simplified version of Floris497's version 4 patch: https://github.com/Floris497/mac-pixel-clock-patch-V2/blob/64f7c7746e8434e59cf9c07e832caf74e965bf0e/CoreDisplay-patcher.command#L120

Tested on a Dell XPS 15 9560 (Intel HD 630 + 4K display) on 10.13.4.

PMheart commented 6 years ago

Hi! Thanks for the patch!

Regards, PMheart

al3xtjames commented 6 years ago

The following (single) patch should also work (leaving this here for reference):

// 10.13.4+
static const uint8_t findBuf1034[] {
    0xBB, 0x01, 0x00, 0x00, 0x00,                   // mov ebx, 0x1
    0xA8, 0x01,                                     // test al, 0x1
    0x0F, 0x85                                      // jne <somewhere>
};

static const uint8_t replBuf1034[] {
    0x48, 0x33, 0xC0,                               // xor eax, eax
    0x90, 0x90, 0x90, 0x90, 0x90,                   // nop (5x)
    0xE9                                            // jmp <somewhere>
};

However, I'm not sure if this is better (might be more fragile when it comes to future updates).

PMheart commented 6 years ago

I have no idea since I don't have such device to test. Anyway, sent you a link to be the collaborator. Feel free to commit the patch if you want. :)

al3xtjames commented 6 years ago

Thanks. I'll keep the existing patch for now, will revisit once 10.13.5 betas come out...

al3xtjames commented 6 years ago

FWIW, both of the patches in this thread should work in 10.13.5b1 (the bytes for the merged set of patches and the other single patch are present).

PMheart commented 6 years ago

I see. Let's keep watching it. You can merge the patch when it's reasonably stable. (Maybe after 10.14 is out or so...)