search

PMunch / binaryparse

Binary parser for Nim
MIT License
71 stars 6 forks source link

peekData*E is wrong #16

Closed codehz closed 3 years ago

codehz commented 3 years ago

it will only read the first byte, since peek won't move the position... https://github.com/PMunch/binaryparse/blob/5f8f4a745ffded841975cd1166b328ee843ff81a/binaryparse.nim#L141-L153

PMunch commented 3 years ago

Not sure how I've missed that, and how it hasn't broken anything yet. Good catch!

PMunch commented 3 years ago

Sorry this has taken so long, fixed in: https://github.com/PMunch/binaryparse/commit/7508fa718bc9bd53a87024081de6f1fdec9bb762