Closed jjacobson95 closed 1 year ago
Before we merge this PR:
Major Changes (higher priority)
.github/workflows/action.yml
)Minor Changes (lower priority)
snekmer/rules/learn.smk
, are capitalized. This naming scheme does not conform to Python conventions requiring variable names to be lowercase (either snake_case
or camelCase
), as capitalized variable names indicate classes by convention.Thanks for the checklist @christinehc! I'll likely start working on this early next week!
Addressed some incompatibilities between learn/apply and the current codebase. Tests are now functioning properly. The only code update left is to remove branch specification in the tests (actions). And once docs are pushed to readthedocs, they will likely require a second pass.
Additive method fixed, however a caveat exists with the scoring method for this revision. While the kmer counts database can be successfully updated, the confidence scoring can't fully account for all of the previous files that entered this database. Lets discuss in next meeting.
Just a note - this should be good to go. No known issues currently exist.
Learn / Apply has been updated with confidence scoring should be good to go.
Documentation will be updated soon as well.