PNNL-CompBio / Snekmer

Pipeline to apply encoded Kmer analysis to protein sequences
BSD 3-Clause "New" or "Revised" License
12 stars 1 forks source link

Kmer association #109

Closed jjacobson95 closed 1 year ago

jjacobson95 commented 1 year ago

Learn / Apply has been updated with confidence scoring should be good to go.

Documentation will be updated soon as well.

christinehc commented 1 year ago

Before we merge this PR:

Major Changes (higher priority)

Minor Changes (lower priority)

jjacobson95 commented 1 year ago

Thanks for the checklist @christinehc! I'll likely start working on this early next week!

jjacobson95 commented 1 year ago

Addressed some incompatibilities between learn/apply and the current codebase. Tests are now functioning properly. The only code update left is to remove branch specification in the tests (actions). And once docs are pushed to readthedocs, they will likely require a second pass.

jjacobson95 commented 1 year ago

Additive method fixed, however a caveat exists with the scoring method for this revision. While the kmer counts database can be successfully updated, the confidence scoring can't fully account for all of the previous files that entered this database. Lets discuss in next meeting.

jjacobson95 commented 1 year ago

Just a note - this should be good to go. No known issues currently exist.