PNNL-CompBio / coderdata

Automation scripts and benchmark dataset package for cancer drug prediction deep learning models.
Other
11 stars 3 forks source link

unable to build docker described in broad_sanger/README.md #166

Closed coleslaw481 closed 6 months ago

coleslaw481 commented 6 months ago

I checkout ur repo (https://github.com/PNNL-CompBio/coderdata) on 5-2-24 and was attempting to build the docker image described on this readme:

https://github.com/PNNL-CompBio/coderdata/blob/main/build/broad_sanger/README.md

and I got this error:

docker build -f ../../build/docker/Dockerfile.broad_sanger -t broad_sanger ../../
[+] Building 0.1s (2/2) FINISHED                                                
 => [internal] load build definition from Dockerfile.broad_sanger          0.0s
 => => transferring dockerfile: 1.00kB                                     0.0s
 => [internal] load .dockerignore                                          0.0s
 => => transferring context: 116B                                          0.0s
failed to solve with frontend dockerfile.v0: failed to create LLB definition: dockerfile parse error line 1: FROM requires either one or three arguments

Command I ran:

# from coderdata/build/broad_sanger directory
docker build -f ../../build/docker/Dockerfile.broad_sanger -t broad_sanger ../../

I am on an intel mac with this version of docker:

docker -v
Docker version 20.10.12, build e91ed57

Am I doing something wrong?

thanks,

chris

coleslaw481 commented 6 months ago

There was a typo in the first line and just went with FROM bioconductor/bioconductor_docker and it built the image (not sure if it is right)

sgosline commented 6 months ago

This docker file is depracated, i recommend using the build script to build the commands.

sgosline commented 6 months ago

I will update the README today.