PNNL-CompBio / coderdata

Automation scripts and benchmark dataset package for cancer drug prediction deep learning models.
Other
11 stars 3 forks source link

Coderdata build_all script does not update download location #202

Closed sgosline closed 2 months ago

sgosline commented 3 months ago

I ran the build_all script yet the yaml file is still the same: https://github.com/PNNL-CompBio/coderdata/blob/main/coderdata/download/figshare_latest.yml

sgosline commented 3 months ago

New data is on figshare but is not downloaded by the package despite running the build_all script with the pypi flag.

https://figshare.com/articles/dataset/CODERData0_1_4/26409316. Current version is 0.1.4.

jjacobson95 commented 3 months ago

Not a lot of details to reproduce this issue here. Looks like a lot of changes to the repo since I've been out as well.

Could you provide the following:

I did notice a small bug at the end of the build_all.py script, that should make this confirm that the args.figshare and figshare_token are not checked before attempting to upload to pypi but I don't think this should have effected your run, although without more details, I wont know.

jjacobson95 commented 3 months ago

As far as the yml file, are you talking about the version on github, or the local version during your run? In your run this would be located at '/tmp/figshare_latest.yml'. The github version is no longer updated with each run as users would need token access to our repository - this was previously automatically updated when we ran our code with Github Actions.

sgosline commented 2 months ago

OK, i'll try to run again. I've updated the version on figshare twice, 0.1.3 and 0.1.4 and the latter needs to be in the python package.

jjacobson95 commented 2 months ago

I think this was pushing but not updating latest version on PyPI.

Latest version (0.1.40): https://pypi.org/project/coderdata/

Previous attempt (0.1.4): https://pypi.org/project/coderdata/0.1.4/