search

PNNL-CompBio / srpAnalytics

This repository contains the code necessary to process any new data for the Superfund Research Program Analytics Portal.
MIT License
5 stars 0 forks source link

fixed typo at readme and srpAnalytics folder in dataQcBmd.py #46

Closed kimdn closed 2 years ago

kimdn commented 2 years ago

Please consider to mege this change (please refer my MS chat for detail).

kimdn commented 2 years ago

@sgosline

So, here is what I found/come to know.

Github based unit test (I think that you established?) works fine. run_tests.sh in srpAnalytics repo works fine as well (except buildv1database.R part that I will raise a flag).

However, when I ran python3 dataQcBmd.py --test-morpho according to README in https://github.com/PNNL-CompBio/srpAnalytics it says

python3 /srpAnalytics/format_morpho_input.py /srpAnalytics/test_files/7_PAH_zf_morphology_data_2020NOV11_tall.csv devel
python3: can't open file '/srpAnalytics/format_morpho_input.py': [Errno 2] No such file or directory

that's why I removed 'srpAnalytics' folder before 'format_morpho_input.py'.

However, once I removed 'srpAnalytics' folder before 'format_morpho_input.py', github based unit tests seem to fail.

When you wrote python3 dataQcBmd.py --test-morpho did you check it is working in your laptop?

sgosline commented 2 years ago

Yes, the readme is incorrect.

kimdn commented 2 years ago

This PR is now deprecated.