search

PNNL-TES / bahn-rs-test

MIT License
2 stars 1 forks source link

Multiple function definitions #4

Open bpbond opened 5 years ago

bpbond commented 5 years ago

Hi @jinshijian

Functions like Rs_comparion_figure and Rs_annual_bahn_test are defined in multiple places, which is super confusing. It would be much better to define them just once.

Screen Shot 2019-04-02 at 8 59 10 PM

Could you clean this up if possible?

bpbond commented 5 years ago

Along with this, I'd suggest cleaning up the repo as much as possible so things are clearer. Anything that's not being actively used can be put into old/.

jinshijian commented 5 years ago

Rs_annual_bahn_test were defined multiple times in different R script. But in 6-bahn_Analysis_function.R was only defined once. So, as a project, it is also not allowed to define a function in different files, right? Good to know and will work on it.

jinshijian commented 5 years ago

I agree, the repo now is mess up, I will clean it.

bpbond commented 5 years ago

it is also not allowed

It's allowed! But it is confusing.