search

PNNL-TES / bahn-rs-test

MIT License
2 stars 1 forks source link

master broken #8

Closed bpbond closed 5 years ago

bpbond commented 5 years ago

Hi @jinshijian - in 30657693 you removed SRDB_V4_Fig1.png which means I now can't knit the document.

Screen Shot 2019-04-04 at 6 47 41 AM
jinshijian commented 5 years ago

Hello Ben, can you try it, it should work now. The markdown document is substantially updated, multiple panels are merged together when necessary. And most importantly, Rs_annual are in y-axis now, and the results changed a lot! But it is more interesting, now. I also replotted the residual vs SPI and PDSI plot, without SPI and PDSI added, the residual show a clear pattern, but when SPI or PDSI added, this pattern disappears!

bpbond commented 5 years ago

Ah @jinshijian – I'm still getting errors when I try to build master. Could we sit down and look it tomorrow?

jinshijian commented 5 years ago

Sure, when works for you? I am available all day. See you tomorrow.

On Sun, Apr 14, 2019 at 8:12 PM Ben Bond-Lamberty notifications@github.com wrote:

Ah @jinshijian https://github.com/jinshijian – I'm still getting errors when I try to build master. Could we sit down and look it tomorrow?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PNNL-TES/bahn-rs-test/issues/8#issuecomment-483071092, or mute the thread https://github.com/notifications/unsubscribe-auth/AMr5kSwX5AzrOe6aWNCzlc9o_hRmeca3ks5vg8QBgaJpZM4ccf1T .

jinshijian commented 5 years ago

Hello Ben, can you try now, the error has been debugged and it can be run through at my end. Please let me know if you still got an error. Thanks, Jinshi

bpbond commented 5 years ago

Yes, it works now! Thank you. Will open a PR request by our meeting tomorrow.