search

POE-Addon-Launcher / PAL2

Path of Exile Addon Launcher and Manager
116 stars 20 forks source link

POE-Trades-Companion doesn't download properly #6

Closed crimory closed 5 years ago

crimory commented 5 years ago

For some reason POE TradeMacro and Path of Building both work fine, but POE-Trades-Companion doesn't.

Steps to reproduce:

  1. click Download for POE-Trades-Companion
  2. it downloads (creates the folder, but the folder is empty)
  3. click on Installed tab - POE-Trades-Companion is not listed there
  4. restart PAL2
  5. Download button for POE-Trades-Companion available again to be pressed (effect is the same)

Note: I downloaded POE-Trades-Companion from github and unpacked it to folder created in step 2, but PAL2 still doesn't see the POE-Trades-Companion

crimory commented 5 years ago

I just realised, that it probably have something to do with POE-Trades-Companion latest release info:

Download POE-Trades-Companion-AHK.zip if the executable is being flagged by your antivirus. Extract the zip and run POE Trades Companion.ahk. You do not need to compile the script, you can simply run the ahk file just like you would do with TradeMacro.

For me - I have to use the .ahk script, but PAL2 tries to use the .exe file - that's my guess.

POE-Addon-Launcher commented 5 years ago

I'll investigate and make it grab the AHK instead.

dhimelick commented 5 years ago

That definitely seems to be the issue. I was able to resolve this by adding exclusions in Windows Defender Security Center for the PAL temp_downloads folder and the POE-Trades-Companion Addon folder.