search

POETSII / Orchestrator

The Orchestrator is the configuration and run-time management system for POETS platforms.
1 stars 1 forks source link

Fixes for XML parsing (don't merge without inspection) #224

Open m8pple opened 3 years ago

m8pple commented 3 years ago

Note : This is not a straight pull request; it's an invitation to cherry pick, rebase, copy whatever. It can be closed whenever you like.

This branch contains fixes for #220 , #221 , and #222 , and means that all v4 XML parsing checks in #208 pass.

While it is merged with 1.0.0-alpha (I think b5615c33a5476c4ed1d1170cbc1abaa4201ad007), it includes some possible repeated changes/fixes in it's history, so you probably don't want to merge it without looking more carefully at all the changes.

mvousden commented 3 years ago

Thanks for taking the time to identify the problems in the issues, and for proposing fixes.

Just to make you aware that I have seen your PR and the issues, and I'll get to them in due time!

heliosfa commented 3 years ago

Looking through the commits, these can be ignored:

These have already been fixed:

These are the ones of interest are:

mvousden commented 3 years ago

Is this still needed in light of #264?