search

POETSII / Orchestrator

The Orchestrator is the configuration and run-time management system for POETS platforms.
1 stars 1 forks source link

Handle unimplemented Supervisor input pins more gracefully #229

Closed heliosfa closed 3 years ago

heliosfa commented 3 years ago

Quick and simple fix to more gracefully handle the (currently) unimplemented InputPin and OutputPin elements under a SupervisorType that are valid in the XML.

Instead of the catch-all 998 Unrecoverable, this now posts a 254 Error for both pin types.

Tested with a selection of valid and invalid XMLs.

Fixes #169

mvousden commented 3 years ago

Looks good to me, but does this failure mode increment some error counter, and/or cause the application to not get typelinked? It would make sense to do this. :sweet_potato:

heliosfa commented 3 years ago

Looks good to me, but does this failure mode increment some error counter, and/or cause the application to not get typelinked? It would make sense to do this. 🍠

There is no error counter as (as per our discussions the other day) it will still try to continue after an E as there "might be something salvageable".

This will link, generate and compile the attached XML successfully, though obviously the behaviour will not be what was expected.

Not ideal but that was the edict?

mvousden commented 3 years ago

There is no error counter as (as per our discussions the other day)

Fair enough.

This will link, generate and compile the attached XML successfully, though obviously the behaviour will not be what was expected.

Not ideal but that was the edict?

I don't remember the edict, but I would generally say that sounds more like a warning than an error, if we're allowing the operator to continue.

Happy for you to follow your gut though.