POETSII / Orchestrator

The Orchestrator is the configuration and run-time management system for POETS platforms.
1 stars 1 forks source link

Softswitch (incorrectly) does not execute OnSend for pins with no edges #265

Closed heliosfa closed 3 years ago

heliosfa commented 3 years ago

Some applications are designed to reuse the Send handler on disconnected pins to flip the state. The current Softswitch design (see Fig 3 below from the Softswitch docs) does a numTgts > 0? check before calling the send handler, only calling the handler if there are edges. @m8pple has pointed out that there are valid cases where you want the send handler to run when there are no edges.

image

The fix is to move the numTgts > 0? check to before the Set headers & Calculate pkt size box in the figure.