Implement Request Idle - Githubissues

POETSII / Orchestrator

The Orchestrator is the configuration and run-time management system for POETS platforms.

1 stars 1 forks source link

Implement Request Idle #274

Closed heliosfa closed 3 years ago

heliosfa commented 3 years ago

This pull request implements the Request Idle behaviour detailed in #234.

The new behvaiour is optional for compatibility purposes, but enabled by default, and controlled by two new Compose commands:

compose /reqidle = *: Enable Request Idle behaviour (default)
compose /noreqidle = *: Disable Request Idle behaviour (existing behaviour)

There is a related docs PR at https://github.com/POETSII/orchestrator-documentation/pull/22 and all of the examples have been updated (and tested) in https://github.com/POETSII/Orchestrator_examples/pull/13

heliosfa commented 3 years ago

The only thing that stands out as missing is a lack of a macro, like RTS() for readyToSend, for requestIdle. Perhaps we can encourage the use of a REQUEST_IDLE() macro, for symmetry? 🍠

I have another set of changes in progress at the moment, and I am also looking to implement the "doSend" flag for OnSend, so I will do it as part of one of those change sets and PR if that is OK?