Closed heliosfa closed 2 years ago
- Given that application writers are permitted to access these types (as this is a user-facing feature), I think they should be introduced in the application documentation, perhaps with a corresponding example handler 🍠.
- I think the application writer should be told that their message payloads are packed tightly - another documentation update perhaps?
I'll do a docs tweak and PR.
- Your APSP changes also seem sane, though I would suggest addressing the signedness warning (just use a cast in the condition?).
Interestingly, I now cannot reproduce this warning.
- Since you're fixing Types for device properties and state only available within that devices handlers #232, can we un-xfail the APSP test? These are denoted in the Bash scripts in
Tests/ReferenceXML
- they callTODO
functions instead ofsuccess
orfailure
functions. Do let me know if you need guidance with this. 🍠- Where I put the 👍, I wondered if
requestIdle
had been implemented. If so, please "activate" the corresponding tests in the same way as the above. 🍠
I have enabled both of these tests.
Turns out that I had done the docs changes ages ago but forgot to PR them...
This PR:
devtyp_{DEVICETYPE}_...
format to{GRAPHTYPE}_{DEVICETYPE}_...
. (fixes #231)DeviceStructs.h
, that is used by all devices and the Supervisor. (fixes #232)#pragma pack(push,1)
to the message stuct header. (partially addresses #240)apsp_vec_barrier_150_10.xml
example that stoped it compiling.The plate heat example has been updated, and a very simple compilation test added, in https://github.com/POETSII/Orchestrator_examples/pull/14.
Vol III B has had some minor updates: docx|pdf
APSP tweaks:
To get the APSP example to compile, I had to add
#include <climits>
to the shared code.I also had to add a
const unsigned
cast to the second parameter in the calls tostd::min
to handle:There is still a warning that I am ignoring for now: