POETSII / Orchestrator

The Orchestrator is the configuration and run-time management system for POETS platforms.
1 stars 1 forks source link

CmDepl.cpp silently ignores file system manipulation failures when deploying binaries #280

Closed heliosfa closed 2 years ago

heliosfa commented 3 years ago

When deploying binaries, CmDepl.cpp seems to ignore failing returns from system calls when manipulating the deployment staging directory.

When trying to deploy a large reactive grid on Byron, CmDepl claims in its microlog that:

Copying binaries from '../Output/Composer/Reactive6__reactive6/bin/*' to '/home/gmb/.orchestrator/app_binaries//Reactive6__reactive6' on the local filesystem...
Binaries copied successfully.

However none of the relevant file system manipulation commands have been executed (file creation dates are not altered and the correct files are not in the output directory), and this causes the run to fail as the correct binaries cannot be found to deploy to the hardware.

First blush, the system call is likely failing due to our old friend of running out of address space but this should be being caught and not being reported as a success.