Remove extra slash when defining target path in CmDepl::DeployGraph.

POETSII / Orchestrator

The Orchestrator is the configuration and run-time management system for POETS platforms.

1 stars 1 forks source link

Closed mvousden closed 2 years ago

mvousden commented 2 years ago

Resolves #279. Tested by simply printing target and checking the slash is missing.

heliosfa commented 2 years ago

Is this going to give us a headache down the road? if the trailing slash in the OCFG is ever removed, this will break.

I guess in an ideal world we would detect slashes to properly form paths?

mvousden commented 2 years ago

Is this going to give us a headache down the road? if the trailing slash in the OCFG is ever removed, this will break.

Is this a job for the pathing system? I reckon it would be better to define that logic all in one place, rather than everywhere a path is used.

I guess in an ideal world we would detect slashes to properly form paths?

Yep. Python's os.path.join this is not.