Resolving OrchBase warnings (#31)

POETSII / Orchestrator

The Orchestrator is the configuration and run-time management system for POETS platforms.

1 stars 1 forks source link

Resolving OrchBase warnings (#31) #37

Closed mvousden closed 5 years ago

mvousden commented 5 years ago

This changeset resolves all of the warnings resulting from source in OrchBase. The warnings removed were:

Various constructors initialising members out of order (-Wreorder)
Pointer printf warnings in dumps (-Wformat)
Unused variables (-Wunused-variable)
A rogue open-comment (-Wcomment)
Incorrect format specifiers for printing STL object sizes (-Wformat)
An overflow warning, because MEM_PER_BOARD does not fit into an unsigned integer (-Woverflow)

heliosfa commented 5 years ago

Provided that the memory missmatch that you fixed in f19b009 isn't going to cause any issues on real boards (e.g. with them only being 32-bit address space), this looks fine and nothing jumps out as being silly.

AlexRast commented 5 years ago

As is, the fix for memory-per-board (f19b009) is not guaranteed to work, because sizeof(unsigned long) is only guaranteed to be 4 or more, that is, 32-bits or greater. Needs to be unsigned long long if you want to represent 2^32.

mvousden commented 5 years ago

Good catch @AlexRast, fixed in 5924e4c8.

heliosfa commented 5 years ago

NB: MLV is sitting with me while we are doing this.