POETSII / tinsel

Manythread RISC-V overlay for FPGA clusters
Other
35 stars 1 forks source link

Hostlink compilation warnings fixes #81

Closed mvousden closed 5 years ago

mvousden commented 5 years ago

So I was adding some debugging to HostLink (so that I could diagnose a bug I've introduced in the Orchestrator), and found some warnings during compilation (after adding -Wall). This changeset addresses these warnings, and adds the -Wall option in the hostlink Makefile.

Built with g++ 7.3.0 (the one on Coleridge).

The tests in tinsel::/tests/ didn't look like hostlink tests, so I've not tested these changes. I'd be happy to do so if you point me to a test gauntlet/

mn416 commented 5 years ago

Thanks @mvousden, merged those.

There's no "test everything please" test script, unfortunately. But these changes are all fine.

mvousden commented 5 years ago

:+1: