POSTECH-CVLab / SCNeRF

[ICCV21] Self-Calibrating Neural Radiance Fields
MIT License
465 stars 45 forks source link

Question about the equations in the paper #15

Closed emjay73 closed 2 years ago

emjay73 commented 2 years ago

Q1 image Is it true that each element of n is divided by c ? not f?

Also, what is the meaning of p' value? undistorted pixel?

Q2 image In this equation, I'm not sure why $z_d$ is multiplied twice.

Q3 image In this equation, why divide it by $r{A,d} \cdot r{A,d}$ instead of $||r_{A,d}||$ ?

Q4 image In this equation, round L in the last term should be round r?

jeongyw12382 commented 2 years ago

Thanks for your questions. We'll double check your questions here and soon give you the reply.

jeongyw12382 commented 2 years ago

An update for this issue.

  1. We have normalized the coordinate of each pixel to [-1, 1] when applying radial distortions. Using f instead of c could also enhance the camera model. However, we expect changing the radial parameters could somewhat show similar behaviors. This setups were fine for our experiments. (+p' is the pixel coordinate after distortions have been applied) 2, 3, 4. You are right. We will update the arXiv preprint soon. Fortunately, the pointed parts do not cause errors in our code or performance. Thanks for your suggestion.
emjay73 commented 2 years ago

About Q1. I thought the purpose of the eq5 is to convert pixel coordinates to normalized coordinate(z=1) as other distortion model does, but what you actually intended was to make pixel coordinates range from -1 to 1 right? And if p' is distorted pixel coordinates, then the ray direction in eq 8 is a distorted ray direction? I expected p' to be undistorted pixel coordinates so it's a bit confusing.

About Q2,3,4 Thank you for your confirmation. You cleared things up.