search

POSTECH-CVLab / point-transformer

This is an unofficial implementation of the Point Transformer paper.
508 stars 99 forks source link

Compiling pointops without THC #73

Open maxim0815 opened 1 year ago

maxim0815 commented 1 year ago

Hey thanks for the code. I don't want to draw attention to a bug here, but just mention a small thing.

I just tried compiling pointops and ran into the following error:

src/knnquery/knnquery_cuda.cpp:2:10: fatal error: THC/THC.h: No such file or directory
    2 | #include <THC/THC.h>
      |          ^~~~~~~~~~~
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

According to this post "TH/THC namespace is dead". Removing the includes for THC within all .cpp files and recompiling works fine. It is therefore no longer required for newer cuda versions.

JunbongJang commented 1 year ago

Thank you! I also encountered the same problem but your solution fixed it.