search

POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
29 stars 19 forks source link

Post-processing v1 grids #252

Open astroJeff opened 7 months ago

astroJeff commented 7 months ago

The post-processing script, as it currently stands, was written with a specific file structure in mind that is consistent with the v2 grids and inconsistent with the v1 grids. This is realized in posydon/grids/io.py, where there is a line:

        variable_names = ["m1", "m2", "initial_period_in_days", "initial_z"]
        for variable_name in variable_names:
            assert variable_name in dirname

Since the v1 grids do not have initial_z in their directory names, the post-processing script fails. This may be a problem in the future as well, if users decide to run grids of just one metallicity, and it will be a challenge to de-bug the script failures.

Furthermore, it appears that additional variables, beyond the four listed above, will not be saved into the tuple indicating unique runs. For instance, if a user tries to vary eccentricity, varcontrol, or some other MESA control, the script will not detect it within the directory naming scheme.

mkruckow commented 7 months ago

An accounting for v1 girds is included in PR #237 see 18).

maxbriel commented 4 months ago

@astroJeff Can this be closed?