POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
25 stars 19 forks source link

Keeping the WD abundances for the step_merged #261

Closed kasdaglie closed 4 months ago

kasdaglie commented 4 months ago

The merging of WD is currently failing because attributes like the "co_core_mass" and some central abundances needed for calculated the merger of WD and stars were set to None during step_CO_HMS_RLO. This PR is trying to find a way to keep this quantities from being erased.

mkruckow commented 4 months ago

Update (Feb 29): Some changes need to be checked and adopted potentially.

ezapartas commented 4 months ago

Some conflicts were raised with development...

kasdaglie commented 4 months ago

@ezapartas @maxbriel I have made my final changes to the PR please let me know if you see something that I missed or something that needs to be improved. I tested it both for linear and nearest neighbor interpolation and it works.