Unifying the code for finding grid boundaries and checking validity in case of ignored data.

POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.

BSD 3-Clause "New" or "Revised" License

25 stars 19 forks source link

Unifying the code for finding grid boundaries and checking validity in case of ignored data. #271

Open kkovlakas opened 4 months ago

kkovlakas commented 4 months ago

[x] Simplify the boundary detection code in MESA grids
[x] Determining if specific runs should be excluded from the calculation of the boundaries.
[ ] When #217 is accepted, perhaps use the possible strings in ignore as a way to determined ignored/failed systems?

astroJeff commented 2 months ago

Update (Apr 11): Code does not affect logic - just a more elegant solution to finding grid boundaries with fewer lines of code. @kkovlakas to test this with a grid to make sure boundaries are unaffected.

astroJeff commented 2 months ago

@kkovlakas, have you had a chance to test this PR yet?

kkovlakas commented 1 month ago

This is a nice simplification of the code. @kkovlakas I was just wondering if a function definition inside a function is a good idea, especially since this is quite a general function. It might be better to define it as another private function of the class. That will also be easier for testing.

Otherwise it looks fine!

I think this function is not going to be used in other methods of the class. So I would keep it hidden to be really "private".

kkovlakas commented 1 month ago

@kkovlakas, have you had a chance to test this PR yet?

Not yet. I was having some issues with Quest, but I am planning to continue again this week.