Fix get_combined_tilt calculation

POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.

BSD 3-Clause "New" or "Revised" License

29 stars 19 forks source link

Fix get_combined_tilt calculation #274

Closed maxbriel closed 6 months ago

maxbriel commented 6 months ago

We reset the BINARY_PROPERTIES before using the get_combined_tilt, as such all binaries that got there failed.

This PR changes it to be after the tilt calculation. I'm not sure what the reset of parameters is used for.

This has to include PR #272 to work.

@kasdaglie found these!

maxbriel commented 6 months ago

Example binary at solar metallicity from @kasdaglie

STAR1 = SingleStar(**{'mass': 52.967313,
                      'state': 'H-rich_Core_H_burning'})
STAR2 = SingleStar(**{'mass': 36.306444,
                      'state': 'H-rich_Core_H_burning',}, )

BINARY = BinaryStar(STAR1, STAR2,  
                    **{'time': 0.0, 'state': 'detached', 'event': 'ZAMS', 'orbital_period':12.877004, 'eccentricity': 0.0},
                    properties = sim_pop)

BINARY.evolve()