search

POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
25 stars 19 forks source link

Offset grid slice plots on the HMS-HMS grids #276

Open maxbriel opened 3 months ago

maxbriel commented 3 months ago

Using the September 2023 grids, I'm trying to plot some population over the grid slices using posydon.visualization.plot_pop.plot_popsyn_over_grid_slice.

When doing so at 2Zsun, additional grid slices are plotted, which are not on the same grid of $\delta q = 0.05$ (see example below). Some even go above q=1. Other metallicities are fine.

Since this is the HMS-HMS grid, I expect all models to be the same grid slices.

The models are always `initial_RLOF'. Is this an issue with the grid or the post-processing? Has this been fixed already?

Example: grid_q_0 28

mkruckow commented 3 months ago

I think this is related to the reruns of columns, where the first model failed to be extrapolated from the ZAMS file. The issue is the following: those have been corrected by starting from a different initial mass and first relaxing the mass to the desired one. But in this way, the directory names contain not the actual ZAMS masses, but the one, which we could extrapolate from the ZAMS models before the relaxation. In case of initial RLO, those models usually fail on the synchronization step. As a consequence they don't have history.data files, hence the masses are recovered from the directory names instead, which are wrong on those cases. Here a possible solution: renaming all the directories to the correct masses in all the reruns, where a ZAMS extrapolation failed. So long those are surely only initial RLO systems and shouldn't hurt to be in the grid.

maxbriel commented 3 months ago

I agree with them not affecting the grid, since it looks like most if not all are initial_RLO.

However, it currently messes up the plotting routine for plotting a population over a grid slice, since the limits are not accurately and the population is plotted on such an "empty" slice. I suggest we fix the plotting routine for this

mkruckow commented 3 months ago

OK, I have renamed the >1000 directories on Quest. Let's see whether there will be any left after getting a new data set.

mkruckow commented 2 weeks ago

@maxbriel , could you please check whether it is solved in the new grid version? If it is fine, please close the issue. If it still happens, get back to me.