search

POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
25 stars 19 forks source link

`spin_orbit_tilt` no longer an output parameter #283

Closed maxbriel closed 1 month ago

maxbriel commented 3 months ago

In the default population_params.ini spin_orbit_tilt is one of the default output options. However with PR #129, this attribute has been removed from the SingleStar and been replaced with: spin_orbit_tilt_first_SN and spin_orbit_tilt_second_SN

The default should be changed or spin_orbit_tilt option should output both.

What is the preferred behaviour here?

maxbriel commented 3 months ago

The naming of the attributes are also different in their initialisation compared to their where they're set?

In SingleStar.py:

if not hasattr(self, 'spin_orbit_tilt_first_SN'):
      self.spin_orbit_tilt_SN1 = None
if not hasattr(self, 'spin_orbit_tilt_second_SN'):
      self.spin_orbit_tilt_SN2 = None

In step_SN.py, one of the sets:

binary.star_1.spin_orbit_tilt_first_SN = tilt
binary.star_2.spin_orbit_tilt_first_SN = tilt

Would this be sufficient as a fix? Commit on max_synpop_population branch for: attribute names - 590e440 population_params_default.ini: 2355763

mpgalleg commented 3 months ago

I prefer spin_orbit_tilt option outputting both.

We use S1, S2, CC1, CC2 etc so it is inconsistent to use first_SN and second_SN. If we can reduce that, especially in the output, that would be best I think.