search

POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
25 stars 19 forks source link

`mt_history_HMS_HMS` unknown for `stable_reverse_MT` #284

Closed maxbriel closed 1 month ago

maxbriel commented 3 months ago

In a population run, the mt_history_HMS_HMS becomes unknown when the interp_class_HMS_HMS is stable_reverse_MT.

Originally this returned: "Stable reverse mass-transfer phase"

The correct output would be Stable/Unstable reverse mass-transfer phase.

mkruckow commented 3 months ago

Yeah, the issue is, that the new interpolation class is asymmetric: there is now "no_MT", "stable_MT", "unstable_MT", and "stable_reverse_MT", which requires that "stable_MT" and "unstable_MT" can't be treated the same way anymore. I added a case for "stable_reverse_MT", where it was missing (see PR #281 ), nevertheless there would still be the option to get a reverse MT correctly treated in case it has the class stable_MT beside stable_reverse_MT.

Btw. it should now hopefully give Stable reverse mass-transfer phase again, and never Unstable reverse mass-transfer phase if the interpolation class is stable_reverse_MT, but Unstable reverse mass-transfer phase should be able for an interpolation class unstable_MT together with MT forward and backward.

mkruckow commented 1 month ago

All cases should be solved, please reopen in case there are any issues found again.