POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
29 stars 19 forks source link

PopSyn: simulated_mass failed binaries double counted #285

Closed maxbriel closed 3 months ago

maxbriel commented 6 months ago

The simulated_mass is all the ZAMS mass added together for normalisation. Currently, this is done using the history of the binary and checking for all the ZAMS lines in that dataframe. However, there are binaries that can fail at ZAMS or at step_HMS_HMS. If the binary fails there, the ZAMS line will be repeated. Thus, artificially increasing the ZAMS mass.

Instead, we could use the S1_mass_i and S2_mass_i in the oneline dataframe. This is the approach I've taken on the max_synpop_population branch.