POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
29 stars 19 forks source link

Generalize and improve on compress MESA #289

Closed mkruckow closed 4 months ago

mkruckow commented 5 months ago
sgossage commented 5 months ago

A minor QOL thing to add might be to list the full paths of the newly created compressed files, to make it clear to new users where things are stored.

mkruckow commented 5 months ago

A minor QOL thing to add might be to list the full paths of the newly created compressed files, to make it clear to new users where things are stored.

No file gets moved or joint with another file. They are compressed individually and in place, e.g. out.txt becomes out.txt.gz at the same location. Hence, I can add a statement like "in place" and/or "by adding extension .gz". But I think, this might be more something to add to the documentation (which I have done now) instead of the screen output.

astroJeff commented 5 months ago

Update (Apr 25): Waiting on @astroJeff to test.

astroJeff commented 4 months ago

Update (May 9): @astroJeff to run test on Quest

mkruckow commented 4 months ago

Adding a try around the removing is a good idea as an additional improvement to the old code.

astroJeff commented 4 months ago

Running script on Quest in /projects/b1119/POSYDON_GRIDS_v2 right now. Everything looks good and seems to be working well