search

POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
25 stars 19 forks source link

BinaryStar.restore() does not reset the `step_names_history` #291

Closed maxbriel closed 1 month ago

maxbriel commented 2 months ago

When rerunning a binary I reset it, but the step_names_history is not reset.

I would have expected for this to remove this history, when calling BinaryStar.restore() or BinaryStar.reset().

celiotine commented 1 month ago

I think this is happening because the step_names are added with a hook class and are not part of the BINARYPROPERTIES. This should hopefully be simple to fix.

celiotine commented 1 month ago

branch to fix this issue is here