Incorrect classification/remnant masses for BHs when using interpolated values in SN step

[celiotine]

When running with use_interp_values = True in the SN settings, there is incorrect handling of some remnant masses. Specifically, these objects are either being misclassified as BHs or are assigned incorrect remnant masses. An example binary where this behavior is present is:

star_1 = SingleStar(**{'mass': 38.741115, 'state': 'H-rich_Core_H_burning',\
                'natal_kick_array': [21.113771, 2.060135, 2.224789, 4.089729]})
star_2 = SingleStar(**{'mass': 27.776178, 'state': 'H-rich_Core_H_burning',\
                'natal_kick_array': [282.712103, 0.296252, 1.628433, 5.623812]})

binary = BinaryStar(star_1, star_2,
                   **{'time': 0.0, 
                      'state': 'detached', 
                      'event': 'ZAMS',
                      'orbital_period': 93.387072, 
                      'eccentricity': 0.0},
                    properties = sim_prop)

Quest .ini file path: /projects/b1119/cliotine/dev_general/debugging/params_Monica.ini

This is the behavior when running with use_interp_values = True (S2 BH is way too low mass or is actually a NS):

This is the behavior when running with use_interp_values = False (S2 BH looks fine):

[mkruckow]

• Could you please add the SN_type to your two examples?
• Can you may take the state binary at the "oRLO2" for your first example to run from there with the change of the use_interp_values to exclude that the slight change in primary mass during its CC don't move the secondary out of the problematic regime, which might be tight.

[celiotine]

Sure, here is the evolution re-evolving from oRLO2. The outcome is similar to above:

With use_interp_values = True:

Re-evolved from oRLO2 w/ use_interp_values = False:

The SN type for the secondary in both cases is CCSN.

[mkruckow]

OK, thanks. Do we save the interpolation class for the compact object formation? If so, is this the same as well?

[celiotine]

I cannot find a way to access the CO interpolation class from the history?

[maxbriel]

@celiotine would you be able to check if this is still an issue, once the IF interpolator fix is implemented?

[celiotine]

Yeah I can do this, will update once completed.