POSYDON-code / POSYDON

POSYDON is a next-generation single and binary-star population synthesis code incorporating full stellar structure and evolution modeling with the use of MESA.
BSD 3-Clause "New" or "Revised" License
29 stars 19 forks source link

Checks when steps get initialized #314

Open mkruckow opened 4 months ago

mkruckow commented 4 months ago

I recently experienced a case that step SN always failed, in the example it was caused by having no SN model which matches. But instead of getting told about this at the beginning of the pop-syn, it run all through letting all systems entering the SN step fail there. Even more striking all systems which didn't get to this step evolved correctly, hence a quick check on a system, whether the run went well gave the wrong impression.

Hence, I'd suggest that we should add checks in the initialization of all steps to tell the user at this point if a step will always fail. I guess, this will be like the adding of the error and warning classes, that different people will need to do this for different steps.